Open
Conversation
sergio-costas
force-pushed
the
add-only-gdm-code-not-gnome-shell
branch
from
f289039 to
2d2db6b
Compare
Draft
sergio-costas
force-pushed
the
add-only-gdm-code-not-gnome-shell
branch
from
aeb22c2 to
5765cd8
Compare
sergio-costas
force-pushed
the
add-only-gdm-code-not-gnome-shell
branch
2 times, most recently
from
084cf33 to
a9a2230
Compare
sergio-costas
force-pushed
the
add-only-gdm-code-not-gnome-shell
branch
from
6f6ba72 to
ed9f8fc
Compare
Draft
sergio-costas
force-pushed
the
add-only-gdm-code-not-gnome-shell
branch
from
ed9f8fc to
d9fedaf
Compare
These are the required changes in core24-desktop to allow gnome shell to work in its own snap.
sergio-costas
force-pushed
the
add-only-gdm-code-not-gnome-shell
branch
from
d9fedaf to
a325b85
Compare
jhenstridge
suggested changes
May 13, 2025
jhenstridge
left a comment
jhenstridge
left a comment
There was a problem hiding this comment.
This looks pretty good. I've left some comments below.
Author
|
Ready for another review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to remove gnome shell itself, delegating it to ubuntu-desktop-session snap. The idea is to use it along with canonical/ubuntu-desktop-session-snap#39